all: remove ethash pow, only retain shims needed for consensus and tests by karalabe · Pull Request #27178 · ethereum/go-ethereum

karalabe · 2023-04-27T13:20:32Z

Remove PoW 😅

The PR also removes the ethash related flags, configs and API methods in a non-backwards compatible way. There is quite a bit of stuff that we'd need to keep dangling in the code to avoid "that one user" not having upgrade issues. As we're right after a fork, there's no immediate urgency to update, might as well bork things now.

~~Probably the PR should add some vocal failure modes for running Geth in non-beacon-ethash mode.~~ Done!

We also need a followup PR to move the consensus things into a legacy or historical package (or directly into the beacon package) and to rewrite the tests to use some beacon shims instead of the current skeletons in ethash. Then we can be free. That needs a bit of refactor so I wanted to start by mass removes and then review the refactors separately more easily.

sandakersmann · 2023-04-27T18:32:33Z

You also have some residue in the lower parts of README.md about running a private miner.

MariusVanDerWijden

SGTM

MariusVanDerWijden · 2023-05-03T10:00:16Z

 }

-func TestGenerateBlockAndImportEthash(t *testing.T) {
-	testGenerateBlockAndImport(t, false)


Shouldn't we also remove the functionality in the test? L 229ff

zhiqiangxu · 2023-06-06T01:24:55Z

Does this mean go-ethereum doesn't support sync from genesis any more?

karalabe · 2023-06-06T06:04:45Z

It can still sync from genesis, but since the PoW part is frozen and can never change any more, verifying the PoW fields are skipped.

…

On Tue, 6 Jun 2023 at 04:25, zhiqiangxu ***@***.***> wrote: Does this mean go-ethereum doesn't support sync from genesis any more? — Reply to this email directly, view it on GitHub <#27178 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAA7UGM7GN75SICGMU7IR5DXJ2BHHANCNFSM6AAAAAAXN3NALU> . You are receiving this because you modified the open/close state.Message ID: ***@***.***>

…sts (ethereum#27178) * all: remove ethash pow, only retain shims needed for consensus and tests * all: thank you linter * all: disallow launching Geth in legacy PoW mode * cmd/env/internal/t8ntool: remove dangling ethash flag

Back before #27178 , we spun up a number of ethash verifiers to verify headers. So we also had tests to ensure that we were indeed able to abort verification even if we had multiple workers running. With PR #27178, we removed the parallelism in verification, and these tests are now failing, since we now just sequentially fire away the results as fast as possible on one routine. This change removes the (sometimes failing) tests

…sts (ethereum#27178) * all: remove ethash pow, only retain shims needed for consensus and tests * all: thank you linter * all: disallow launching Geth in legacy PoW mode * cmd/env/internal/t8ntool: remove dangling ethash flag

Back before ethereum#27178 , we spun up a number of ethash verifiers to verify headers. So we also had tests to ensure that we were indeed able to abort verification even if we had multiple workers running. With PR ethereum#27178, we removed the parallelism in verification, and these tests are now failing, since we now just sequentially fire away the results as fast as possible on one routine. This change removes the (sometimes failing) tests

…s and tests (ethereum#27178)" This reverts commit 3eb5306.

As per ethereum/go-ethereum#27178 it removes the PoW and some of the API methods with it. SeedHash is one of them.

The corresponding function was removed in #27178

…2495) The corresponding function was removed in ethereum#27178

Reintroduce ethash (purged upstream PR ethereum#27178) and add the ETC consensus engine wrapper. Required for any PoW chain support. - consensus/ethash: full restore of Ethash with mmap-based DAG, sealer, algorithm internals, RPC API, and DAG verification. - consensus/etc: ETC engine wraps ethash and adds ECIP-1017 monetary policy + ECIP-1010 bomb defuse rewards adjustments. - core/vm: ETC-specific EVM behavior (Mystique = London without EIP-1559, Spiral activates EIP-3860 subset, EIP-160 ETC-specific timing). - core/state_transition, core/txpool/validation: IntrinsicGas honors Spiral as an EIP-3860 activator. - go.mod, go.sum: +github.com/edsrzf/mmap-go (for DAG mmap), promote gonum.org/v1/gonum to direct (used by sealer for nonce distribution). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Reintroduce total-difficulty-aware chain state for perpetual PoW chains. Upstream purged TD from the canonical chain in PRs ethereum#27178 and ethereum#29281 as part of the post-Merge cleanup; ETC needs it back. - core/rawdb: TD accessors + PoW ancient scheme entries. - core/blockchain, core/blockchain_pow: PoW-aware block insertion paths that consult TD. - core/headerchain, core/headerchain_pow: TD propagation through header chain. - core/forkchoice_pow: TD-based forkchoice for PoW. - core/genesis, core/genesis_etc: ETC genesis presets (Classic, Mordor) honor ECIP-1041/1099 etc. - eth/ethconfig: Ethash config field on Config; PoW-specific defaults in config_pow.go. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Reintroduce ethash (purged upstream PR ethereum#27178) and add the ETC consensus engine wrapper. Required for any PoW chain support. - consensus/ethash: full restore of Ethash with mmap-based DAG, sealer, algorithm internals, RPC API, and DAG verification. - consensus/etc: ETC engine wraps ethash and adds ECIP-1017 monetary policy + ECIP-1010 bomb defuse rewards adjustments. - core/vm: ETC-specific EVM behavior (Mystique = London without EIP-1559, Spiral activates EIP-3860 subset, EIP-160 ETC-specific timing). - core/state_transition, core/txpool/validation: IntrinsicGas honors Spiral as an EIP-3860 activator. - go.mod, go.sum: +github.com/edsrzf/mmap-go (for DAG mmap), promote gonum.org/v1/gonum to direct (used by sealer for nonce distribution). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Reintroduce total-difficulty-aware chain state for perpetual PoW chains. Upstream purged TD from the canonical chain in PRs ethereum#27178 and ethereum#29281 as part of the post-Merge cleanup; ETC needs it back. - core/rawdb: TD accessors + PoW ancient scheme entries. - core/blockchain, core/blockchain_pow: PoW-aware block insertion paths that consult TD. - core/headerchain, core/headerchain_pow: TD propagation through header chain. - core/forkchoice_pow: TD-based forkchoice for PoW. - core/genesis, core/genesis_etc: ETC genesis presets (Classic, Mordor) honor ECIP-1041/1099 etc. - eth/ethconfig: Ethash config field on Config; PoW-specific defaults in config_pow.go. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Upstream purged TD when it dropped pre-merge sync (PR ethereum#29281) and removed it from the canonical chain (PR ethereum#27178). Reintroduce the TD-aware code paths needed by an ETC node: - core/rawdb: TD accessors (ReadTd / WriteTd / DeleteTd), the PoW ancient scheme entries, and the TD-aware chain freezer. - core/blockchain: TD propagation through block insertion (forker consultation, TD bookkeeping during chain reorgs). - core/blockchain_pow: PoW chain helpers that consult TD. - core/headerchain, core/headerchain_pow: TD through HeaderChain. - core/forkchoice_pow: the TD-based forkchoice algorithm. - core/genesis: write the genesis TD on Commit. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

karalabe requested review from gballet, holiman, rjl493456442, s1na and zsfelfoldi as code owners April 27, 2023 13:20

rjl493456442 reviewed Apr 28, 2023

View reviewed changes

Comment thread cmd/evm/internal/t8ntool/flags.go Outdated

karalabe added 4 commits May 3, 2023 10:17

all: remove ethash pow, only retain shims needed for consensus and tests

c4919e4

all: thank you linter

04a1702

all: disallow launching Geth in legacy PoW mode

003cce1

cmd/env/internal/t8ntool: remove dangling ethash flag

dacec24

karalabe added this to the 1.11.7 milestone May 3, 2023

karalabe merged commit dde2da0 into ethereum:master May 3, 2023

MariusVanDerWijden approved these changes May 3, 2023

View reviewed changes

This was referenced May 3, 2023

Remove ethash to make go-ethereum hive work sunnyside-io/hive#7

Merged

Remove ethash to make go-ethereum hive work ethereum-optimism/hive#81

Merged

s1na mentioned this pull request May 3, 2023

clients/go-ethereum: remove deprecated PoW ethereum/hive#773

Merged

s1na mentioned this pull request May 24, 2023

Deprecate flags for ethash mining #25825

Closed

dindinw mentioned this pull request May 30, 2023

v1.1.0 progress Qitmeer/qng#452

Closed

37 tasks

levikobi mentioned this pull request May 31, 2023

fix make geth-up ardanlabs/smartcontract#7

Merged

Rjected mentioned this pull request Jun 1, 2023

fix: remove deprecated mining threads arg gakonst/ethers-rs#2452

Merged

3 tasks

lightclient mentioned this pull request Jun 26, 2023

miner.start() no longer works. #27607

Closed

jmcook1186 mentioned this pull request Jun 26, 2023

[website]: remove some ethash info from docs #27612

Merged

lightclient mentioned this pull request Jul 4, 2023

Remove mining namespace ethereum/execution-apis#430

Merged

holiman mentioned this pull request Jul 6, 2023

core: remove outdated tests #27662

Merged

devopsbo3 added a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023

Revert "all: remove ethash pow, only retain shims needed for consensu…

552cc4f

…s and tests (ethereum#27178)" This reverts commit 3eb5306.

devopsbo3 added a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023

Revert "all: remove ethash pow, only retain shims needed for consensu…

003e5b2

…s and tests (ethereum#27178)" This reverts commit 3eb5306.

rjl493456442 mentioned this pull request Dec 12, 2023

geth --mine --miner.etherbase 0x5495530c79f10A6a894b7E3EB27a39B41424dE40 not working anymore #28671

Closed

YoshihitoAso mentioned this pull request Mar 19, 2024

[FEATURE] Remove ethash pow BoostryJP/quorum#77

Closed

dimpar added a commit to mezo-org/mezod that referenced this pull request Aug 29, 2024

Removing SeedHash

422b99b

As per ethereum/go-ethereum#27178 it removes the PoW and some of the API methods with it. SeedHash is one of them.

gartnera mentioned this pull request Oct 22, 2024

upgrade go-ethereum zeta-chain/ethermint#141

Merged

2 tasks

This was referenced Aug 25, 2025

all: remove ethash pow #27178 XinFinOrg/XDPoSChain#1378

Merged

internal/web3ext: remove deprecated method debug_seedHash #32495

Merged

rjl493456442 pushed a commit that referenced this pull request Aug 26, 2025

internal/web3ext: remove deprecated method debug_seedHash (#32495)

16bd164

The corresponding function was removed in #27178

gballet pushed a commit to gballet/go-ethereum that referenced this pull request Sep 11, 2025

internal/web3ext: remove deprecated method debug_seedHash (ethereum#3…

dd95f73

…2495) The corresponding function was removed in ethereum#27178

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

all: remove ethash pow, only retain shims needed for consensus and tests#27178

all: remove ethash pow, only retain shims needed for consensus and tests#27178
karalabe merged 4 commits into
ethereum:masterfrom
karalabe:nuke-pow

karalabe commented Apr 27, 2023 •

edited

Loading

Uh oh!

sandakersmann commented Apr 27, 2023

Uh oh!

Uh oh!

MariusVanDerWijden left a comment

Uh oh!

MariusVanDerWijden May 3, 2023

Uh oh!

zhiqiangxu commented Jun 6, 2023

Uh oh!

karalabe commented Jun 6, 2023 via email

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

karalabe commented Apr 27, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sandakersmann commented Apr 27, 2023

Uh oh!

Uh oh!

MariusVanDerWijden left a comment

Choose a reason for hiding this comment

Uh oh!

MariusVanDerWijden May 3, 2023

Choose a reason for hiding this comment

Uh oh!

zhiqiangxu commented Jun 6, 2023

Uh oh!

karalabe commented Jun 6, 2023 via email

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

karalabe commented Apr 27, 2023 •

edited

Loading